Merge pull request #272 from hhyasdf/cherry-pick/manager-should-not-work-with-old-crds

[CHERRY PICK] make manager unable to work with old crds

Author: mars1024

cmd/manager/main.go

@@ -125,7 +125,7 @@ func main() {
 		os.Exit(1)
 	}
 
-	// init IPAM manager and stort
+	// init IPAM manager and start
 	ipamManager, err := networking.NewIPAMManager(globalContext, mgr.GetClient())
 	if err != nil {
 		entryLog.Error(err, "unable to create IPAM manager")

pkg/apis/networking/v1/conversion.go

@@ -68,7 +68,7 @@ func CanonicalizeIPInstance(c client.Client) (err error) {
 	var patchFuncs []func() error
 	for i := range ipInstanceList.Items {
 		var ipInstance = &ipInstanceList.Items[i]
-		if parseIPInstanceVersion(ipInstance) == IPInstanceLatestVersion {
+		if parseIPInstanceVersion(ipInstance) == IPInstanceLatestVersion && !IsLegacyModel(ipInstance) {
 			continue
 		}
 

pkg/controllers/networking/pod_ip_cache.go

@@ -67,6 +67,11 @@ func NewPodIPCache(ctx context.Context, c client.Reader, logger logr.Logger) (Po
 	}
 
 	for _, ip := range ipList.Items {
+		if networkingv1.IsLegacyModel(&ip) {
+			return nil, fmt.Errorf("get legacy model ip instance, if this happens more than once, " +
+				"please check if the networking CRD yamls is updated to the latest v0.5 version")
+		}
+
 		podName := networkingv1.FetchBindingPodName(&ip)
 		if len(podName) != 0 {
 			var podUID types.UID