feat(interactive): Implement service register and primary election #4589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committed-by: xiaolei.zl from Dev container
|
Please check the preview of the documentation changes at |
zhanglei1949
requested review from
Copilot,
liulx20 and
luoxiaojian
and removed request for
liulx20
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new integration test for the service registry and primary election features by adding a dedicated CI job in the GitHub Actions workflow.
- Adds a new "test-service-registry" job to validate the etcd-based service registry and primary election via a series of scripted steps.
- Configures the environment, downloads and launches etcd, executes the interactive_server, and validates key outputs.
Files not reviewed (15)
- .gitmodules: Language not supported
- flex/CMakeLists.txt: Language not supported
- flex/cmake/BuildEtcdCpp.cmake: Language not supported
- flex/engines/http_server/CMakeLists.txt: Language not supported
- flex/engines/http_server/actor/admin_actor.act.cc: Language not supported
- flex/engines/http_server/graph_db_service.cc: Language not supported
- flex/engines/http_server/graph_db_service.h: Language not supported
- flex/engines/http_server/service_register.cc: Language not supported
- flex/engines/http_server/service_register.h: Language not supported
- flex/storages/rt_mutable_graph/schema.cc: Language not supported
- flex/storages/rt_mutable_graph/schema.h: Language not supported
- flex/third_party/cpprestsdk: Language not supported
- flex/third_party/etcd-cpp-apiv3: Language not supported
- flex/utils/service_utils.cc: Language not supported
- flex/utils/service_utils.h: Language not supported
Co-authored-by: Copilot <[email protected]>
liulx20
previously approved these changes
Mar 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4589 +/- ##
=======================================
Coverage 44.76% 44.76%
=======================================
Files 12 12
Lines 592 592
=======================================
Hits 265 265
Misses 327 327 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Committed-by: xiaolei.zl from Dev container
|
/cc @yecol @sighingnow, this issus/pr has had no activity for a long time, please help to review the status and assign people to work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
etcd-cpp-api-v3andcpprestsdkas submodule dependencies.ServiceRegisterwhich registers the server itself to the etcd-based service registry.promote()function, which should be called after adding the primary key-value pair succeeds.