Fix compile error for the flash bc algorithm on ubuntu #2839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committed-by: 有理 from Dev container
acezen
approved these changes
Jun 8, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2839 +/- ##
==========================================
- Coverage 73.91% 66.77% -7.14%
==========================================
Files 99 99
Lines 10665 10665
==========================================
- Hits 7883 7122 -761
- Misses 2782 3543 +761 see 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committed-by: 有理 from Dev container
What do these changes do?
Some compilers were failing to match the most suitable overloaded functions when
EjoinVis used in the FLASH model , causing unexpected errors. So I add an extra parameter to force the compiler to use the required overloaded function.This change is intended to ensure that the function is correctly matched by the compiler and that the program runs correctly.
Related issue number
Fixes #2835