Skip to content

Fix Docker Install and setup.py dependencies #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

luijait
Copy link

@luijait luijait commented Jun 23, 2024

During the installation of the repository version, I encountered several errors that made the installation process:

  1. Outdated Dockerfile

Some packages installed via apt either no longer existed or had updated names, specifically gcc-aarch64-linux-gnu. Additionally, it was necessary to re-clone the repository once the Docker container was created.
Furthermore, some essential packages like build-essential were missing, causing compilation errors in the script.
Solution: Update the package, automate workspace creation in Docker, add build-essential (babeltrace still needs to be installed from source)

  1. Outdated Dependencies

Due to version conflicts between updated and non-updated packages (numpy, dedupe, dedupe-datetime, etc.), it was impossible to run setup.py install. This caused numpy to install a version lacking some methods used in the script.
Solution: Pin versions in setup.py

  1. PyCVESearch - The CVESearch method requires a base URL for directing requests

Solution: Add a base_url parameter to cve_search() (wrapper for CVESearch()) with the default URL https://cvepremium.circl.lu/

  1. Lack of documentation for running modules, only the entrypoint is indicated in setup.py
    Solution: Add a brief tutorial to the README
    These improvements should significantly enhance the installation process and usability of the repository.

@vmayoral vmayoral merged commit e3d2424 into aliasrobotics:master Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants