Skip to content

Upgrade to py-sdk v2.0 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 11, 2023
Merged

Upgrade to py-sdk v2.0 #46

merged 5 commits into from
Jan 11, 2023

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Jan 11, 2023

No description provided.

tzaffi
tzaffi reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the need to upgrade to py-sdk v2 is relatively urgent, so I don't want to hold up this PR. However, I did have a question regarding come casts in graviton/abi_strategy.py

@ahangsu ahangsu marked this pull request as ready for review January 11, 2023 19:24
@ahangsu ahangsu requested a review from tzaffi January 11, 2023 19:25
tzaffi
tzaffi approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for upgrading to pysdk v2 and for the general improvements in the code construction!

@ahangsu ahangsu merged commit 0241483 into main Jan 11, 2023
@ahangsu ahangsu deleted the py-sdk-v2 branch January 11, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzaffi tzaffi tzaffi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahangsu @tzaffi