This repository was archived by the owner on Dec 30, 2022. It is now read-only.
chore(examples): update next example to Next 12 #3438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit be11b39:
|
dhayab
reviewed
Apr 20, 2022
Co-authored-by: François Chalifour <[email protected]>
Co-authored-by: François Chalifour <[email protected]>
✅ Deploy Preview for react-instantsearch ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| debouncedSetState.current = setTimeout(() => { | ||
| const href = searchStateToURL(nextSearchState); | ||
|
|
||
| router.push(href, href, { shallow: true }); |
There was a problem hiding this comment.
This seems to overwrite the router history, not to append (see preview).
There was a problem hiding this comment.
can you screen record?
Untitled.mov
There was a problem hiding this comment.
It seems to happen when you open the CodeSandbox app in a tab. It might be another CodeSandbox bug.
francoischalifour
approved these changes
Apr 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Result
Example is updated
see https://github.com/algolia/react-instantsearch/discussions/3434
Before this PR gets merged, the documentation should be updated, as it references this sandbox I think