feat: Slider widget #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvo
changed the title
added 4 commits
September 15, 2015 01:40
eyes only, webpack build in error
I dunno how to author ES6 modules and provide them to our clients. It seems that https://github.com/bloodyowl/stile/blob/68b8350f4134ae2182a60c9f55442be92b4ce26e/scripts/build.js and https://github.com/bloodyowl/stile/blob/68b8350f4134ae2182a60c9f55442be92b4ce26e/webpack.config.js is one solution
+ using `algolia/react-nouislider` was able to externalize it even being written in ES6 (just use babel-cli) + moved lib/widget-utils to lib/utils because used in both widgets and components
so you can access it when on the same network
| * Instantiate a slider based on a numeric attribute | ||
| * @param {String|DOMElement} options.container Valid CSS Selector as a string or DOMElement | ||
| * @param {String} options.facetName Name of the attribute for faceting | ||
| * @param {Boolean|Object} [options.tooltips=true] Should we show tooltips or not. |
There was a problem hiding this comment.
What is the default tooltip message if I use only true?
There was a problem hiding this comment.
What is the default tooltip message if I use only true?
We just show the formatted tooltip value. So in the current case it would be "5.99" instead of "$5.99"
There was a problem hiding this comment.
Would be cool to have some information about that in the doc :)
added 5 commits
September 15, 2015 10:40
We now use our style-loader fork to be able to `prepend` a component `<style>` instead of appending it to the `<head>`. So that we can now override component style from a stylesheet in the html page.
|
@algolia/javascript This PR is done on my side, if ok with you, merge! |
|
LGTM |
aymeric-giraudet
pushed a commit
that referenced
this pull request
Dec 8, 2022
sarahdayan
pushed a commit
that referenced
this pull request
Dec 12, 2022
* feat(CurrentRefinements): add query and remove reset * feat: includedAttributes
sarahdayan
pushed a commit
that referenced
this pull request
Dec 14, 2022
* feat(CurrentRefinements): add query and remove reset * feat: includedAttributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
components