-
Notifications
You must be signed in to change notification settings - Fork 543
feat(recommend): add Trending-Facets model #6556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
6e760d8
to
bc997e5
Compare
@algolia/frontend-experiences-web hi team, this is not urgent, but can someone help figure out go the fix the V4 types 🙏 ? |
packages/instantsearch.js/src/connectors/trending-facets/types.ts
Outdated
Show resolved
Hide resolved
c077e94
to
c02fee6
Compare
packages/instantsearch-ui-components/src/components/TrendingFacets.tsx
Outdated
Show resolved
Hide resolved
c02fee6
to
9137cc8
Compare
packages/instantsearch-ui-components/src/components/TrendingFacets.tsx
Outdated
Show resolved
Hide resolved
2806db3
to
be5ab5c
Compare
Originally we didn't implement trending facets as it's not clear how we want to incorporate the filtering / links inside it, as it could be many different attributes, refinement types. However, it makes sense to be able to fully deprecate the old recommend widgets, and so we'll need trending facets too. What we'll need to be able to later create a filtering directly from this widget I think is to make the itemComponent required here, so changing the default isn't a breaking change. |
121fc18
to
5bfd850
Compare
Summary
Add Recommend model
trending-facets
TODO
sendEvent
(Recommend analytics does not supporttrending-facets
)