Skip to content

feat(recommend): add Trending-Facets model #6556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

raed667
Copy link
Contributor

@raed667 raed667 commented Feb 10, 2025

Summary

Add Recommend model trending-facets

TODO

  • Figure out what to do with sendEvent (Recommend analytics does not support trending-facets)
  • Implement tests

@raed667 raed667 requested review from marialungu, dhayab, sarahdayan and aymeric-giraudet and removed request for marialungu February 10, 2025 07:16
Copy link

codesandbox-ci bot commented Feb 10, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@raed667 raed667 force-pushed the feat/recommend/trending-facets branch 2 times, most recently from 6e760d8 to bc997e5 Compare February 10, 2025 07:56
@raed667
Copy link
Contributor Author

raed667 commented Feb 10, 2025

@algolia/frontend-experiences-web hi team, this is not urgent, but can someone help figure out go the fix the V4 types 🙏 ?

@raed667 raed667 force-pushed the feat/recommend/trending-facets branch 2 times, most recently from c077e94 to c02fee6 Compare February 10, 2025 09:04
@raed667 raed667 force-pushed the feat/recommend/trending-facets branch from c02fee6 to 9137cc8 Compare February 10, 2025 10:08
@raed667 raed667 force-pushed the feat/recommend/trending-facets branch 3 times, most recently from 2806db3 to be5ab5c Compare February 11, 2025 10:37
@Haroenv
Copy link
Contributor

Haroenv commented Feb 11, 2025

Originally we didn't implement trending facets as it's not clear how we want to incorporate the filtering / links inside it, as it could be many different attributes, refinement types.

However, it makes sense to be able to fully deprecate the old recommend widgets, and so we'll need trending facets too.

What we'll need to be able to later create a filtering directly from this widget I think is to make the itemComponent required here, so changing the default isn't a breaking change.

@Haroenv Haroenv force-pushed the feat/recommend/trending-facets branch from 121fc18 to 5bfd850 Compare June 23, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants