chore(examples): use local polyfills when possible #6076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 51cf925:
|
dhayab
force-pushed
the
chore/replace-polyfill-io
branch
from
78aa494 to
bed9085
Compare
dhayab
changed the title
dhayab
changed the title
dhayab
commented
Feb 26, 2024
dhayab
commented
Feb 26, 2024
dhayab
requested review from
a team,
sarahdayan and
aymeric-giraudet
and removed request for
a team
Haroenv
reviewed
Feb 27, 2024
|
Redrafting the PR, since this morning even the pinned version of the polyfill.io URL fails. |
dhayab
force-pushed
the
chore/replace-polyfill-io
branch
from
2567a45 to
51cf925
Compare
Haroenv
approved these changes
Feb 27, 2024
| module.exports = { | ||
| flavors: ['js', 'js-umd', 'react', 'vue'].filter( |
There was a problem hiding this comment.
there's a small chance this is used in jsdoc type somewhere, do you mind checking? not sure if I changed it to string at a later point
There was a problem hiding this comment.
I looked at the current codebase and commits in the change history of this file, I could not find anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For our e2e tests we add polyfills in e-commerce examples, to include unsupported methods in IE11. This PR replaces remote polyfill links with local scripts.
Important
With this PR, IE11 testing is only performed on InstantSearch.js (
jsandjs-umd). This change is temporary.→ Passing CI