fix(api): rename hideContainerWhenNoResults to autoHideContainer #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvo
force-pushed
the
fix/hideContainerWhenNoResults-autoHideContainer
branch
from
f806bee to
d619576
Compare
+ updated jsdoc + updated some widgets algorithm to hide/show (numeric widgets) + had to rename the decorators require to $decoratorHOC (High Order Component, the pattern we use). fixes #407 BREAKING CHANGE: use autoHideContainer instead of hideContainerWhenNoResults
vvo
force-pushed
the
fix/hideContainerWhenNoResults-autoHideContainer
branch
from
d619576 to
3f64bef
Compare
|
👍 LGTM |
bobylito
added a commit
that referenced
this pull request
Nov 6, 2015
…utoHideContainer fix(api): rename hideContainerWhenNoResults to autoHideContainer
|
👍 |
| @@ -72,7 +72,7 @@ function numericRefinementList({ | |||
| return option; | |||
| }); | |||
|
|
|||
| let hasNoResults = facetValues.length === 0; | |||
| let hasNoResults = results.nbHits === 0; | |||
There was a problem hiding this comment.
No because the facetValues are manually set thus they are always here (you always have facetValues)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly copy pasting
Component, the pattern we use).
fixes #407
BREAKING CHANGE: use autoHideContainer instead of
hideContainerWhenNoResults