chore(warnings): Remove test warning about type should not be null
#374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning `Warning: React.createElement: type should not be null, undefined, boolean, or number. It should be a string (for DOM elements) or a ReactClass (for composite components).` was caused by calling the test decorator on `<div />` instead of `'div'`. As the message suggest, we should use strings for basic DOM elements.
|
Oh good catch :/ |
redox
added a commit
that referenced
this pull request
Oct 28, 2015
chore(warnings): Remove test warning about `type should not be null`
| @@ -27,7 +27,7 @@ describe('autoHideContainer', () => { | |||
| }); | |||
|
|
|||
| function render(props = {}) { | |||
| var AutoHide = autoHideContainer(<span />); | |||
| var AutoHide = autoHideContainer('span'); | |||
There was a problem hiding this comment.
I am not sure what we are testing here, the signature of autoHideContainer is:
function autoHideContainer(ComposedComponent) {and the render:
return <ComposedComponent {...this.props} />;So yes we fixed the warnings but we have another issue I feel here
There was a problem hiding this comment.
You're right. I'll update with a TestComponent() {render() {}} instead
This was referenced Oct 28, 2015
aymeric-giraudet
pushed a commit
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning
Warning: React.createElement: type should not be null, undefined, boolean, or number. It should be a string (for DOM elements) or a ReactClass (for composite components).was caused bycalling the test decorator on
<div />instead of'div'.As the message suggest, we should use strings for basic DOM elements.