fix: More explicit error message when DOM selector is invalid #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,13 +1,21 @@ | |||
| function getContainerNode(selectorOrHTMLElement) { | |||
| if (typeof selectorOrHTMLElement === 'string') { | |||
| return document.querySelector(selectorOrHTMLElement); | |||
| var isFromString = (typeof selectorOrHTMLElement === 'string'); | |||
There was a problem hiding this comment.
Is there a need for parenthesis here?
There was a problem hiding this comment.
Seems they are not needed indeed
|
Great, only waiting for comment on (type of) |
|
They might not be needed, but I feel they improve readability. |
Ok no preference here |
|
LGTM |
pixelastic
added a commit
that referenced
this pull request
Sep 22, 2015
fix: More explicit error message when DOM selector is invalid
aymeric-giraudet
pushed a commit
that referenced
this pull request
Dec 8, 2022
sarahdayan
pushed a commit
that referenced
this pull request
Dec 12, 2022
When you click these buttons in latest Chrome, it will keep those buttons on the same place in the viewport, which means that users will skip the next page of results. With this property added, that's fixed. This solution comes from https://bugs.chromium.org/p/chromium/issues/detail?id=1110323#c1 and has been verified by three customers so far.
sarahdayan
pushed a commit
that referenced
this pull request
Dec 14, 2022
When you click these buttons in latest Chrome, it will keep those buttons on the same place in the viewport, which means that users will skip the next page of results. With this property added, that's fixed. This solution comes from https://bugs.chromium.org/p/chromium/issues/detail?id=1110323#c1 and has been verified by three customers so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105