Skip to content

Toggle issue #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jerska opened this issue Nov 2, 2015 · 4 comments
Closed

Toggle issue #408

Jerska opened this issue Nov 2, 2015 · 4 comments

Comments

@Jerska
Copy link
Member

Jerska commented Nov 2, 2015

Related to #219 .

The toggle widget doesn't really do what it does : it just checks, when enabled, that a facet is true.
However, there is no way to toggle it to false, making its behaviour different from what its name could make us think.

The behaviour I expect from a toggle button is a binary behaviour: http://www.bootstrap-switch.org/examples.html , and right now when the checkbox is unchecked, we're actually in the Indeterminate example of this page.

@vvo
Copy link
Contributor

vvo commented Nov 2, 2015

Relevant discussions also: #41 (comment)

We had trouble naming this one or finding a good API that allow both use cases in an easy to understand way.

Do you have any idea how to make it clearer/better. For sure this issue will be raised by people :)

@Jerska
Copy link
Member Author

Jerska commented Nov 2, 2015

What about something like constantFilter ?
This would allow this one to be more generic, and could even maybe even accept an optional operator to handle use cases like Past week or Past month, etc. or My favorites (which would be favorited_by_ids:my_id), etc.
WDYT ?

@Jerska
Copy link
Member Author

Jerska commented Nov 2, 2015

Actually, Past week, past month would require a list so it should probably go in another widget. But My favorites still makes sense to me.

@vvo
Copy link
Contributor

vvo commented Nov 2, 2015

Clsoing in favor of #409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants