Skip to content

fix(javascript): use transporter directly #3682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Sep 9, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2893

Changes included:

using this forces is to bind the client, we can avoid it by directly using the transporter

supersede algolia/instantsearch#6352
close algolia/instantsearch#6350
close algolia/algoliasearch-client-javascript#1549

@shortcuts shortcuts self-assigned this Sep 9, 2024
@shortcuts shortcuts requested a review from a team as a code owner September 9, 2024 16:29
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 9, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 57ca876e9359bc88efdf569b7b78da88ad8c0e7a
🍃 Generated commit e4257b3512238f80bd638759818535d3561a8126
🌲 Generated branch generated/fix/avoid-transporter-bind
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1628

Fluf22
Fluf22 previously approved these changes Sep 9, 2024
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated ✅

Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🙌🙌

@shortcuts shortcuts merged commit 0a433cc into main Sep 9, 2024
14 checks passed
@shortcuts shortcuts deleted the fix/avoid-transporter-bind branch September 9, 2024 18:53
algolia-bot added a commit that referenced this pull request Sep 9, 2024
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants