Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test samples #94

Merged
merged 1 commit into from
Jan 28, 2016
Merged

Unit test samples #94

merged 1 commit into from
Jan 28, 2016

Conversation

airleks
Copy link

@airleks airleks commented Jan 28, 2016

This pull request is sample of unit test cases that we plan to contribute in order to raise the overall coverage to 80%. Code coverage is measured using Intellij IDEA. This pull request increases code coverage of library from 0% to 15%.

Metric | Before | After
Coverage % | 0% | 15%
Lines Covered | 0 | 45
Total Lines | 291 | 291
Please let me know if you have any questions.

Alexey Syrtsev
DevFactory - Code Quality Team

@airleks
Copy link
Author

airleks commented Jan 28, 2016

Greetings @alexec. Circleci verification failed on unauthorized plugin deployment attempt. Is it ok for PR or there is a way to fix it?
The circleci error message is below

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.8.1:deploy (default-deploy) on project docker-maven-plugin: Failed to deploy artifacts: Could not transfer artifact com.alexecollins.docker:docker-maven-plugin:jar:2.11.10-20160128.101200-4 from/to sonatype-nexus-snapshots (https://oss.sonatype.org/content/repositories/snapshots/): Failed to transfer file: https://oss.sonatype.org/content/repositories/snapshots/com/alexecollins/docker/docker-maven-plugin/2.11.10-SNAPSHOT/docker-maven-plugin-2.11.10-20160128.101200-4.jar. Return code is: 401, ReasonPhrase: Unauthorized. -> [Help 1]

@alexec
Copy link
Owner

alexec commented Jan 28, 2016

Great stuff.

alexec added a commit that referenced this pull request Jan 28, 2016
@alexec alexec merged commit 4a525bc into alexec:master Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants