movie_lib.cc: Fix incorrect return type of getOffset
#195
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexbatalov Can you please merge this? The bug was introduced in your changes to my PR #117 when you were merging it. |
|
@alexbatalov @glebm This also fixes the artifacting issue mentioned in #136 on OpenBSD. |
|
@alexbatalov @glebm it fixes the issue #136 pls can you merge it? thx |
|
@alexbatalov I see you're committing stuff again, can you please merge this? |
|
I can confirm that this PR fixed the FMV issue I was experiencing in my WIP Xbox port. I say it should definitely be merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type was changed from
autotouint8_twhen merging #117, but the correct return type is actuallyint.Fixes #136
Fixes #194
There is an alternative fix in #188 (with a graph of generated values) but I think the return type there (
int16_t) is incorrect./cc @alexbatalov @Zenkibou @hippydave @KulikAlex @dje4321