Fixes and updates for Windows #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to use path.join instead of path.resolve as on Windows path.resolve will add in the drive letter (C:\temp isntead of c:\[ftpdir]\temp). Enforced user directory creation, added userdirectory to success() callback, and quit hit update for X commands as used by Windows FTP.
|
Would this break support for someone that tried to do "CWD ../../abcd" from a command line client to change directories? |
|
It shouldn't, but as I don't use Linux I'd say test it :). I just fixed it for Windows. |
|
Pretty sure it'll break that functionality for windows too. Have you tried CWD with relative paths like I mentioned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to use path.join instead of path.resolve as on Windows
path.resolve will add in the drive letter (C:\temp isntead of
c:[ftpdir]\temp). Enforced user directory creation, added
userdirectory to success() callback, and quit hit update for X commands
as used by Windows FTP.