Skip to content

Make HandleActorTaskSchedulerMessage method protected virtual #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2023
Merged

Make HandleActorTaskSchedulerMessage method protected virtual #6763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37bedaa
Make `HandleActorTaskSchedulerMessage` method `protected virtual`
Arkatufus May 16, 2023
1c6ede4
Update API Verify list
Arkatufus May 16, 2023
4c4d3bb
Merge branch 'dev' into change-task-message-handler-protected
Aaronontheweb May 16, 2023
8ea6144
Merge branch 'dev' into change-task-message-handler-protected
Aaronontheweb May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ namespace Akka.Actor
public static Akka.Actor.IActorRef GetCurrentSelfOrNoSender() { }
public static Akka.Actor.IActorRef GetCurrentSenderOrNoSender() { }
public Akka.Actor.IInternalActorRef GetSingleChild(string name) { }
[Akka.Annotations.InternalApiAttribute()]
protected virtual void HandleActorTaskSchedulerMessage(Akka.Dispatch.SysMsg.ActorTaskSchedulerMessage m) { }
public void Init(bool sendSupervise, Akka.Dispatch.MailboxType mailboxType) { }
public Akka.Actor.Internal.ChildRestartStats InitChild(Akka.Actor.IInternalActorRef actor) { }
public void Invoke(Akka.Actor.Envelope envelope) { }
Expand Down Expand Up @@ -3127,6 +3129,16 @@ namespace Akka.Dispatch.SysMsg
public ActorTask(System.Threading.Tasks.Task task) { }
public System.Threading.Tasks.Task Task { get; }
}
[Akka.Annotations.InternalApiAttribute()]
public sealed class ActorTaskSchedulerMessage : Akka.Dispatch.SysMsg.SystemMessage
{
public ActorTaskSchedulerMessage(Akka.Dispatch.ActorTaskScheduler scheduler, System.Threading.Tasks.Task task, object message) { }
public ActorTaskSchedulerMessage(System.Exception exception, object message) { }
public System.Exception Exception { get; }
public object Message { get; }
public void ExecuteTask() { }
public override string ToString() { }
}
public sealed class Create : Akka.Dispatch.SysMsg.SystemMessage
{
public Create(Akka.Actor.ActorInitializationException failure = null) { }
Expand Down
12 changes: 12 additions & 0 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Net.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ namespace Akka.Actor
public static Akka.Actor.IActorRef GetCurrentSelfOrNoSender() { }
public static Akka.Actor.IActorRef GetCurrentSenderOrNoSender() { }
public Akka.Actor.IInternalActorRef GetSingleChild(string name) { }
[Akka.Annotations.InternalApiAttribute()]
protected virtual void HandleActorTaskSchedulerMessage(Akka.Dispatch.SysMsg.ActorTaskSchedulerMessage m) { }
public void Init(bool sendSupervise, Akka.Dispatch.MailboxType mailboxType) { }
public Akka.Actor.Internal.ChildRestartStats InitChild(Akka.Actor.IInternalActorRef actor) { }
public void Invoke(Akka.Actor.Envelope envelope) { }
Expand Down Expand Up @@ -3119,6 +3121,16 @@ namespace Akka.Dispatch.SysMsg
public ActorTask(System.Threading.Tasks.Task task) { }
public System.Threading.Tasks.Task Task { get; }
}
[Akka.Annotations.InternalApiAttribute()]
public sealed class ActorTaskSchedulerMessage : Akka.Dispatch.SysMsg.SystemMessage
{
public ActorTaskSchedulerMessage(Akka.Dispatch.ActorTaskScheduler scheduler, System.Threading.Tasks.Task task, object message) { }
public ActorTaskSchedulerMessage(System.Exception exception, object message) { }
public System.Exception Exception { get; }
public object Message { get; }
public void ExecuteTask() { }
public override string ToString() { }
}
public sealed class Create : Akka.Dispatch.SysMsg.SystemMessage
{
public Create(Akka.Actor.ActorInitializationException failure = null) { }
Expand Down
4 changes: 3 additions & 1 deletion src/core/Akka/Actor/ActorCell.DefaultMessages.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
using Akka.Event;
using Debug = Akka.Event.Debug;
using System.Globalization;
using Akka.Annotations;

namespace Akka.Actor
{
Expand Down Expand Up @@ -334,7 +335,8 @@ internal void SystemInvoke(ISystemMessage envelope)
SysMsgInvokeAll(new EarliestFirstSystemMessageList((SystemMessage)envelope), CalculateState());
}

private void HandleActorTaskSchedulerMessage(ActorTaskSchedulerMessage m)
[InternalApi]
protected virtual void HandleActorTaskSchedulerMessage(ActorTaskSchedulerMessage m)
{
//set the current message captured in the async operation
//current message was cleared earlier when the async receive handler completed
Expand Down
3 changes: 2 additions & 1 deletion src/core/Akka/Dispatch/SysMsg/ISystemMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,8 @@ public ActorTask(Task task)
/// <summary>
/// TBD
/// </summary>
internal sealed class ActorTaskSchedulerMessage : SystemMessage
[InternalApi]
public sealed class ActorTaskSchedulerMessage : SystemMessage
{
private readonly ActorTaskScheduler _scheduler;
private readonly Task _task;
Expand Down