Skip to content

[FIX][pre][code] CSS problem #6756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 15, 2023
Merged

[FIX][pre][code] CSS problem #6756

merged 9 commits into from
May 15, 2023

Conversation

eaba
Copy link
Contributor

@eaba eaba commented May 10, 2023

No description provided.

@eaba eaba marked this pull request as draft May 11, 2023 11:15
@eaba eaba marked this pull request as ready for review May 11, 2023 11:48
@eaba eaba marked this pull request as draft May 11, 2023 11:50
@eaba
Copy link
Contributor Author

eaba commented May 11, 2023 •
edited
Loading

I want to create another branch for footer? @Aaronontheweb

@eaba eaba marked this pull request as ready for review May 11, 2023 12:02
@Aaronontheweb
Copy link
Member

I want to create another branch for footer? @Aaronontheweb

that should be fine. Can you post screenshots of the new homepage here?

@eaba
Copy link
Contributor Author

eaba commented May 11, 2023

before:

image

after:

image

@Aaronontheweb
Copy link
Member

I want to create another branch for footer? @Aaronontheweb

Based on our convo it in Slack, sounds like problems with the footer are the result of this PR. That needs to be fixed too before we can merge this.

@eaba
Copy link
Contributor Author

eaba commented May 11, 2023 •
edited
Loading

https://getakka.net/api/Akka.Cluster.TestKit.html https://getakka.net/api/Akka.Actor.Internal.html

maybe just increase the height? Footer new PR?

@eaba
Copy link
Contributor Author

eaba commented May 11, 2023

image

Aaronontheweb
Aaronontheweb requested changes May 12, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain why you made these changes?

docs/template/styles/docfx.js Outdated
} else {
resetBottomCss();
// $("footer").fadeOut();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eaba this was disabled so the footer would stay persistent at the bottom of the site. Why did you add it back?

Aaronontheweb
Aaronontheweb requested changes May 12, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain why you made these changes?

@eaba
Copy link
Contributor Author

eaba commented May 12, 2023

I will revert it. First, I thought that the new changes are docfx v2.67.0. Second, @Arkatufus give me idea yesterday, I tried it, not the problem. Removing footer solved it!

@Aaronontheweb
Copy link
Member

I will revert it. First, I thought that the new changes are docfx v2.67.0. Second, @Arkatufus give me idea yesterday, I tried it, not the problem. Removing footer solved it!

thanks @eaba - I'll try running this again locally.

Aaronontheweb
Aaronontheweb reviewed May 15, 2023
View reviewed changes
docs/docfx.json
],
"postProcessors": ["ExtractSearchIndex"],
"noLangKeyword": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add all three of these deleted settings back

Aaronontheweb
Aaronontheweb requested changes May 15, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided that we add the required docfx.json settings back

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) May 15, 2023 14:09
@Aaronontheweb Aaronontheweb merged commit 37cb4c6 into akkadotnet:dev May 15, 2023
@eaba eaba deleted the CSS branch May 15, 2023 14:59
@Aaronontheweb Aaronontheweb mentioned this pull request May 15, 2023
Closed
Arkatufus added a commit to Arkatufus/akka.net that referenced this pull request May 15, 2023
@Arkatufus
Revert "[FIX][pre][code] CSS problem (akkadotnet#6756)"
c1a273c 
This reverts commit 37cb4c6.
@Arkatufus Arkatufus mentioned this pull request May 15, 2023
Merged
Aaronontheweb pushed a commit that referenced this pull request May 15, 2023
@Arkatufus
Revert DocFX changes (#6738, #6756) (#6759)
d7da8dd 
* Revert "[FIX][pre][code] CSS problem (#6756)"

This reverts commit 37cb4c6.

* Revert "[Doc] Upgrade to `Docfx 2.67.0` (#6738)"

This reverts commit 66f348a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eaba @Aaronontheweb