Skip to content

fix some xunit warnings #6752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/core/Akka.Tests/Configuration/HoconTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public void Can_parse_sub_config()
var config = ConfigurationFactory.ParseString(hocon);
var subConfig = config.GetConfig("a");
Assert.Equal(1, subConfig.GetInt("b.c"));
Assert.Equal(true, subConfig.GetBoolean("b.d"));
Assert.True(subConfig.GetBoolean("b.d"));
}


Expand Down Expand Up @@ -149,9 +149,9 @@ public void Can_parse_hocon()
var config = ConfigurationFactory.ParseString(hocon);
Assert.Equal("1", config.GetString("root.int"));
Assert.Equal("1.23", config.GetString("root.double"));
Assert.Equal(true, config.GetBoolean("root.bool"));
Assert.Equal(true, config.GetBoolean("root.object.hasContent"));
Assert.Equal(null, config.GetString("root.null"));
Assert.True(config.GetBoolean("root.bool"));
Assert.True(config.GetBoolean("root.object.hasContent"));
Assert.Null(config.GetString("root.null"));
Assert.Equal("foo", config.GetString("root.quoted-string"));
Assert.Equal("bar", config.GetString("root.unquoted-string"));
Assert.Equal("foo bar", config.GetString("root.concat-string"));
Expand Down Expand Up @@ -184,9 +184,9 @@ public void Can_parse_json()
var config = ConfigurationFactory.ParseString(hocon);
Assert.Equal("1", config.GetString("root.int"));
Assert.Equal("1.23", config.GetString("root.double"));
Assert.Equal(true, config.GetBoolean("root.bool"));
Assert.Equal(true, config.GetBoolean("root.object.hasContent"));
Assert.Equal(null, config.GetString("root.null"));
Assert.True(config.GetBoolean("root.bool"));
Assert.True(config.GetBoolean("root.object.hasContent"));
Assert.Null(config.GetString("root.null"));
Assert.Equal("foo", config.GetString("root.string"));
Assert.True(new[] {1, 2, 3}.SequenceEqual(ConfigurationFactory.ParseString(hocon).GetIntList("root.array")));
}
Expand Down Expand Up @@ -218,7 +218,7 @@ public void Can_override_object()
a.c = 3
";
var config = ConfigurationFactory.ParseString(hocon);
Assert.Equal(null, config.GetString("a.b"));
Assert.Null(config.GetString("a.b"));
Assert.Equal("3", config.GetString("a.c"));
}

Expand Down Expand Up @@ -355,14 +355,14 @@ public void Can_assign_null_to_field()
public void Can_assign_boolean_to_field()
{
var hocon = @"a=true";
Assert.Equal(true, ConfigurationFactory.ParseString(hocon).GetBoolean("a"));
Assert.True(ConfigurationFactory.ParseString(hocon).GetBoolean("a"));
hocon = @"a=false";
Assert.Equal(false, ConfigurationFactory.ParseString(hocon).GetBoolean("a"));
Assert.False(ConfigurationFactory.ParseString(hocon).GetBoolean("a"));

hocon = @"a=on";
Assert.Equal(true, ConfigurationFactory.ParseString(hocon).GetBoolean("a"));
Assert.True(ConfigurationFactory.ParseString(hocon).GetBoolean("a"));
hocon = @"a=off";
Assert.Equal(false, ConfigurationFactory.ParseString(hocon).GetBoolean("a"));
Assert.False(ConfigurationFactory.ParseString(hocon).GetBoolean("a"));
}

[Fact]
Expand Down Expand Up @@ -742,7 +742,7 @@ public void Can_substitute_object()
public void Can_assign_null_string_to_field()
{
var hocon = @"a=null";
Assert.Equal(null, ConfigurationFactory.ParseString(hocon).GetString("a"));
Assert.Null(ConfigurationFactory.ParseString(hocon).GetString("a"));
}

[Fact(Skip = "we currently do not make any distinction between quoted and unquoted strings once parsed")]
Expand Down