Skip to content

[CS0420] ActorCell Warning Disable #6683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 4, 2023
Merged

[CS0420] ActorCell Warning Disable #6683

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e718687
[CS0420] `ActorCell` Warning Disable
eaba Apr 26, 2023
bd24e35
Merge branch 'dev' into ActorCell
eaba Apr 27, 2023
4c2150b
Merge branch 'dev' into ActorCell
eaba Apr 28, 2023
6b71110
Merge branch 'dev' into ActorCell
eaba May 3, 2023
32d1398
Merge branch 'dev' into ActorCell
eaba May 3, 2023
85bac30
[fix] Removed the `Volatile.Read`
eaba May 4, 2023
3518579
Merge branch 'dev' into ActorCell
eaba May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/core/Akka/Actor/ActorCell.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,9 @@ public ActorCell(ActorSystemImpl system, IInternalActorRef self, Props props, Me
/// <summary>
/// TBD
/// </summary>
#pragma warning disable CS0420 // A reference to a volatile field will not be treated as volatile
public Mailbox Mailbox => Volatile.Read(ref _mailboxDoNotCallMeDirectly);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably remove the Volatile.Read call - since the field is already volatile.

#pragma warning restore CS0420 // A reference to a volatile field will not be treated as volatile
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. A volatile field should not normally be passed using a ref or out parameter, since it will not be treated as volatile within the scope of the function. There are exceptions to this, such as when calling an interlocked API. As with any warning, you may use the [#pragma warning](https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/preprocessor-directives#pragma-warning) to disable this warning in those rare cases where you are intentionally using a volatile field as a reference parameter. https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0420?f1url=%3FappId%3Droslyn%26k%3Dk(CS0420)

  2. public Mailbox Mailbox => _mailboxDoNotCallMeDirectly;


/// <summary>
/// TBD
Expand Down