Lock persistence journal table on write #6639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Change journal table write transaction isolation from undefined to serializable.
This is done to prevent a racy condition in a very write heavy environment, coupled with very eager read on the database.
The explanation for this is here: https://learn.microsoft.com/en-us/sql/t-sql/statements/create-table-transact-sql-identity-property?view=sql-server-ver15#remarks
Basically, for an identity column to be guaranteed to be assigned sequential number during concurrent writes is to lock the table so that only one transaction can operate on the table at any given time.
Performance Comparison
Performance was measured on MS SQL Server, 5 runs were done on each variant and only the highest result is taken, this is to assume that the most optimal condition was used on each test.
Numbers are measured in total messages per second.