Skip to content

[63-74] SinkForeachParallelSpec #6611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2023
Merged

[63-74] SinkForeachParallelSpec #6611

merged 3 commits into from
Mar 30, 2023

Conversation

eaba
Copy link
Contributor

@eaba eaba commented Mar 26, 2023

Changes

  • Change AssertAllStagesStopped to AssertAllStagesStoppedAsync

@@ -19,6 +19,7 @@
using System.Threading;
using Akka.Streams.TestKit;
using Akka.TestKit.Xunit2.Attributes;
using System.Threading.Tasks;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new async TestKit methods and try to avoid Task.Wait et al

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit e18567a into akkadotnet:dev Mar 30, 2023
@eaba eaba deleted the SinkForeachParallelSpec branch March 30, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants