-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[54-74] LazySinkSpec
#6601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[54-74] LazySinkSpec
#6601
Conversation
{ | ||
await probe.Value.ExpectNextAsync(i); | ||
} | ||
//I CHECK IT THIS IS NOT GOOD - EVERYTHING WORKS FINE NOW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//I CHECK IT THIS IS NOT GOOD - EVERYTHING WORKS FINE NOW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some cleanup but otherwise looks good
sourceSub.SendNext(i); | ||
await probe.ExpectNextAsync(i); | ||
} | ||
//I CHECK IT THIS IS NOT GOOD - EVERYTHING WORKS FINE NOW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove any comments that aren't functional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
AssertAllStagesStopped
toAssertAllStagesStoppedAsync