Skip to content

[54-74] LazySinkSpec #6601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 4, 2023
Merged

[54-74] LazySinkSpec #6601

merged 6 commits into from
Apr 4, 2023

Conversation

eaba
Copy link
Contributor

@eaba eaba commented Mar 25, 2023

Changes

  • Change AssertAllStagesStopped to AssertAllStagesStoppedAsync

{
await probe.Value.ExpectNextAsync(i);
}
//I CHECK IT THIS IS NOT GOOD - EVERYTHING WORKS FINE NOW
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//I CHECK IT THIS IS NOT GOOD - EVERYTHING WORKS FINE NOW

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some cleanup but otherwise looks good

sourceSub.SendNext(i);
await probe.ExpectNextAsync(i);
}
//I CHECK IT THIS IS NOT GOOD - EVERYTHING WORKS FINE NOW
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove any comments that aren't functional

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 95c1266 into akkadotnet:dev Apr 4, 2023
@eaba eaba deleted the LazySinkSpec branch April 4, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants