Akka.Streams: fix race conditions with synchronous file sink specs #6565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Mar 24, 2023
| @@ -444,7 +444,7 @@ public void SynchronousFileSink_should_write_buffered_element_if_manual_flush_is | |||
| ActorMaterializer materializer, | |||
| bool create = true) | |||
| { | |||
| var targetFile = new FileInfo(Path.Combine(Path.GetTempPath(), "synchronous-file-sink.tmp")); | |||
| var targetFile = new FileInfo(Path.Combine(Path.GetTempPath(), $"synchronous-file-sink-{Guid.NewGuid()}.tmp")); | |||
There was a problem hiding this comment.
Append a new Guid for unique randomization
Arkatufus
approved these changes
Mar 24, 2023
|
This one is still failing Leads me to believe there's an issue with the spec design itself there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Akka.Streams.Tests.IO.FileSinkSpec.SynchronousFileSink_should_allow_appending_to_fileand other specs frequently fail with errors such as:This is because we use a static file name and other tests might not be finished fully disposing / disposed cleanly when trying to access this file. Now we randomize the file name on each individual test in order to keep them isolated.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):