[CS1998] This async method lacks 'await' operators and will run synchronously #6513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaba
commented
Mar 13, 2023
| @@ -184,7 +184,8 @@ protected override bool ReceivePluginInternal(object message) | |||
|
|
|||
| private async Task<(IEnumerable<string> Ids, int LastOrdering)> SelectAllPersistenceIdsAsync(int offset) | |||
| { | |||
| return (new HashSet<string>(_allMessages.Skip(offset).Select(p => p.PersistenceId)), _allMessages.Count); | |||
| return await Task.FromResult((new HashSet<string>(_allMessages.Skip(offset).Select(p => p.PersistenceId)), _allMessages.Count)); | |||
There was a problem hiding this comment.
Let's talk about this @Aaronontheweb @Arkatufus
There was a problem hiding this comment.
I'd remove the async and the await here - just returning the Task.Result should be fine.
eaba
commented
Mar 13, 2023
| @@ -207,7 +208,8 @@ private async Task<int> ReplayTaggedMessagesAsync(ReplayTaggedMessages replay) | |||
| index++; | |||
| } | |||
|
|
|||
| return _tagsToMessagesMapping[replay.Tag].Count - 1; | |||
| return await Task.FromResult(_tagsToMessagesMapping[replay.Tag].Count - 1); | |||
There was a problem hiding this comment.
Let's talk about this @Aaronontheweb @Arkatufus
|
@eaba is this ready for review? |
|
I will tell you @Aaronontheweb |
- `TestPublisher.cs` - `Utils.cs` - `EventFilterApplier.cs` - `BlockingQueue.cs` - `TestKitBase_AwaitConditions.cs` - `TestKitBase_Within.cs`
This is broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
"warning CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread."
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksInclude data from the relevant benchmark prior to this change here.
This PR's Benchmarks
Include data from after this change here.