[Obsolete][CS0618] AwaitResult > Use ShouldCompleteWithin instead
#6498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…akka.net into use_should_complete_within
| { | ||
| var task = AggregateSource.RunWith(Sink.First<int>(), Materializer); | ||
| task.AwaitResult().Should().Be(Expected); |
There was a problem hiding this comment.
What does AwaitResult do and is it different than ShouldCompleteWithin?
There was a problem hiding this comment.
"warning CS0618: 'Utils.AwaitResult(Task, TimeSpan?)' is obsolete: 'Use ShouldCompleteWithin instead'"
Aaronontheweb
requested changes
Mar 8, 2023
Arkatufus
requested changes
Mar 9, 2023
Arkatufus
requested changes
Mar 9, 2023
…akka.net into use_should_complete_within
Arkatufus
requested changes
Mar 10, 2023
Arkatufus
requested changes
Mar 10, 2023
|
@eaba I think you have some more additional comments from @Arkatufus that need to be addressed from his last review |
…akka.net into use_should_complete_within
Arkatufus
approved these changes
Mar 17, 2023
Aaronontheweb
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.