Fixes FailChunkExecution does not handle DbExceptions wrapped in an AggregateException
#6361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismaelhamed
commented
Jan 25, 2023
| ? aggregateException.Flatten().InnerExceptions.OfType<DbException>().FirstOrDefault() | ||
| ?? aggregateException.Flatten().InnerExceptions[0] | ||
| : message.Cause; | ||
|
|
There was a problem hiding this comment.
An alternative to this would be to stop throwing an AggregateException in line #1003
… `AggregateException`
ismaelhamed
force-pushed
the
batchingjournal-fix
branch
from
6ff06f3 to
de387c2
Compare
|
@ismaelhamed do we need to backport this to v1.4? |
|
Yes. We have a customer that is being impacted by this. |
|
@ismaelhamed we can do a deploy today if that'd help you |
|
That'd be great @Aaronontheweb |
|
If you can send the PR, I'll prepare the release notes and take care of that today. |
ismaelhamed
added a commit
to ismaelhamed/akka.net
that referenced
this pull request
Jan 26, 2023
… `AggregateException` (akkadotnet#6361)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6362