-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Improve Akka.Cluster.Metrics collected values #6203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Aaronontheweb
merged 9 commits into
akkadotnet:v1.4
from
Arkatufus:Improve_metrics_collection
Oct 28, 2022
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6df8ea5
Improve collected values
Arkatufus 9d1f44d
Merge branch 'v1.4' into Improve_metrics_collection
Arkatufus 77a99f3
Update API Verify list
Arkatufus 23baf70
Fix metrics collection
Arkatufus 5960356
Fix documentation
Arkatufus 4d94d34
Update API Verify list
Arkatufus 78c86a0
Merge branch 'v1.4' into Improve_metrics_collection
Aaronontheweb d77f14d
Update DefaultCollector.cs
Aaronontheweb 213a8bf
Update DefaultCollector.cs
Aaronontheweb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,13 +55,14 @@ public NodeMetrics Sample() | |
{ | ||
using (var process = Process.GetCurrentProcess()) | ||
{ | ||
process.Refresh(); | ||
var metrics = new List<NodeMetrics.Types.Metric>() | ||
{ | ||
// Memory | ||
// Forcing garbage collection to keep metrics more resilent to occasional allocations | ||
NodeMetrics.Types.Metric.Create(StandardMetrics.MemoryUsed, GC.GetTotalMemory(true)).Value, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be GC |
||
// VirtualMemorySize64 is not best idea here... | ||
NodeMetrics.Types.Metric.Create(StandardMetrics.MemoryAvailable, process.VirtualMemorySize64).Value, | ||
|
||
// total committed process memory = working set + paged | ||
NodeMetrics.Types.Metric.Create(StandardMetrics.MemoryAvailable, process.WorkingSet64 + process.PagedMemorySize64).Value, | ||
// CPU Processors | ||
NodeMetrics.Types.Metric.Create(StandardMetrics.Processors, Environment.ProcessorCount).Value, | ||
}; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this is wrong - shouldn't we just cache this value somewhere?