Skip to content

Simplified hocon data structure implementation #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Feb 25, 2020

This PR looks bad, but its actually rather small.

Most of the changes are related to missing using Akka.Configuration and using Hocon declaration, only a handful of files needs code changes, and they are related to the removal of HoconRoot, HoconField, and HoconValue.

Before merging:

  • make sure that the new Hocon library nuget is referenced in the project
  • make sure to clean up reference to experimental nuget package repo

….HoconConfigurationFactory and use of static extensions for value getters.
# Conflicts:
#	src/benchmark/Akka.Benchmarks/Hocon/HoconBenchmarks.cs
#	src/benchmark/PingPong/Program.cs
#	src/benchmark/RemotePingPong/Program.cs
#	src/benchmark/SpawnBenchmark/Program.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests.MultiNode/ClusterShardingCustomShardAllocationSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests.MultiNode/ClusterShardingFailureSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests.MultiNode/ClusterShardingGetStateSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests.MultiNode/ClusterShardingGetStatsSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests.MultiNode/ClusterShardingGracefulShutdownSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests.MultiNode/ClusterShardingLeavingSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests.MultiNode/ClusterShardingMinMembersSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests.MultiNode/ClusterShardingRememberEntitiesNewExtractorSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests.MultiNode/ClusterShardingRememberEntitiesSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests.MultiNode/ClusterShardingSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests/ClusterShardingConfigSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests/ClusterShardingInternalsSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests/ClusterShardingSettingsSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests/CoordinatedShutdownShardingSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests/DDataClusterShardingConfigSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests/GetShardTypeNamesSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests/InactiveEntityPassivationSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests/PersistentShardSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests/ProxyShardingSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding.Tests/SupervisionSpec.cs
#	src/contrib/cluster/Akka.Cluster.Sharding/ClusterSharding.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests.MultiNode/ClusterClient/ClusterClientHandoverSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests.MultiNode/ClusterClient/ClusterClientSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests.MultiNode/ClusterClient/ClusterClientStartSpecConfig.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests.MultiNode/ClusterClient/ClusterClientStopSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests.MultiNode/PublishSubscribe/DistributedPubSubMediatorSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests.MultiNode/PublishSubscribe/DistributedPubSubRestartSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests.MultiNode/Singleton/ClusterSingletonManagerChaosSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests.MultiNode/Singleton/ClusterSingletonManagerDownedSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests.MultiNode/Singleton/ClusterSingletonManagerLeave2Spec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests.MultiNode/Singleton/ClusterSingletonManagerLeaveSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests.MultiNode/Singleton/ClusterSingletonManagerSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests.MultiNode/Singleton/ClusterSingletonManagerStartupSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests/ClusterClient/ClusterClientConfigSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests/ClusterClient/ClusterClientMessageSerializerSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests/PublishSubscribe/DistributedPubSubConfigSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests/PublishSubscribe/DistributedPubSubMediatorRouterSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests/PublishSubscribe/DistributedPubSubMediatorSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests/PublishSubscribe/DistributedPubSubMessageSerializerSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests/Singleton/ClusterSingletonConfigSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests/Singleton/ClusterSingletonLeavingSpeedSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests/Singleton/ClusterSingletonMessageSerializerSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests/Singleton/ClusterSingletonProxySpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests/Singleton/ClusterSingletonRestart2Spec.cs
#	src/contrib/cluster/Akka.Cluster.Tools.Tests/Singleton/ClusterSingletonRestartSpec.cs
#	src/contrib/cluster/Akka.Cluster.Tools/Client/ClusterClientReceptionist.cs
#	src/contrib/cluster/Akka.Cluster.Tools/PublishSubscribe/DistributedPubSub.cs
#	src/contrib/cluster/Akka.Cluster.Tools/Singleton/ClusterSingletonManager.cs
#	src/contrib/cluster/Akka.Cluster.Tools/Singleton/ClusterSingletonProxy.cs
#	src/contrib/cluster/Akka.DistributedData.Tests.MultiNode/DurableDataSpec.cs
#	src/contrib/cluster/Akka.DistributedData.Tests.MultiNode/DurablePruningSpec.cs
#	src/contrib/cluster/Akka.DistributedData.Tests.MultiNode/JepsenInspiredInsertSpec.cs
#	src/contrib/cluster/Akka.DistributedData.Tests.MultiNode/ReplicatorChaosSpec.cs
#	src/contrib/cluster/Akka.DistributedData.Tests.MultiNode/ReplicatorPruningSpec.cs
#	src/contrib/cluster/Akka.DistributedData.Tests.MultiNode/ReplicatorSpec.cs
#	src/contrib/cluster/Akka.DistributedData.Tests/LocalConcurrencySpec.cs
#	src/contrib/cluster/Akka.DistributedData.Tests/Serialization/ReplicatedDataSerializerSpec.cs
#	src/contrib/cluster/Akka.DistributedData.Tests/Serialization/ReplicatorMessageSerializerSpec.cs
#	src/contrib/cluster/Akka.DistributedData.Tests/WriteAggregatorSpec.cs
#	src/contrib/cluster/Akka.DistributedData/DistributedData.cs
#	src/contrib/cluster/Akka.DistributedData/Serialization/ReplicatorMessageSerializer.cs
#	src/contrib/persistence/Akka.Persistence.Query.Sql/SqlReadJournal.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/AssemblyVersioning/BackwardsCompatSqliteJournalSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/AssemblyVersioning/BackwardsCompatSqliteSnapshotStoreSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Batching/BatchingSqliteCurrentEventsByPersistenceIdSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Batching/BatchingSqliteCurrentEventsByTagSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Batching/BatchingSqliteCurrentPersistenceIdsSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Batching/BatchingSqliteEventsByPersistenceIdSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Batching/BatchingSqliteEventsByTagSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Batching/BatchingSqliteJournalConnectionFailureSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Batching/BatchingSqliteJournalSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Batching/BatchingSqlitePersistenceIdSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Performance/SqliteJournalPerfSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Query/SqliteCurrentEventsByPersistenceIdSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Query/SqliteCurrentEventsByTagSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Query/SqliteCurrentPersistenceIdsSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Query/SqliteEventsByPersistenceIdSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Query/SqliteEventsByTagSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Query/SqlitePersistenceIdsSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Serialization/SqliteJournalSerializationSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/Serialization/SqliteSnapshotStoreSerializationSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/SqliteJournalConnectionFailureSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/SqliteJournalSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/SqliteSnapshotStoreConnectionFailureSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite.Tests/SqliteSnapshotStoreSpec.cs
#	src/contrib/persistence/Akka.Persistence.Sqlite/Extension.cs
#	src/contrib/serializers/Akka.Serialization.Hyperion.Tests/HyperionConfigTests.cs
#	src/contrib/serializers/Akka.Serialization.TestKit/AkkaSerializationSpec.cs
#	src/contrib/testkits/Akka.TestKit.Xunit/TestKit.cs
#	src/contrib/testkits/Akka.TestKit.Xunit2/TestKit.cs
#	src/core/Akka.Cluster.TestKit/MultiNodeClusterSpec.cs
#	src/core/Akka.Cluster.TestKit/MultiNodeLoggingConfig.cs
#	src/core/Akka.Cluster.Tests.MultiNode/ClusterAccrualFailureDetectorSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/ClusterDeathWatchSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/ConvergenceSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/DeterministicOldestWhenJoiningSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/DisallowJoinOfTwoClustersSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/InitialHeartbeatSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/JoinInProgressSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/JoinSeedNodeSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/LeaderDowningAllOtherNodesSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/LeaderDowningNodeThatIsUnreachableSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/MemberWeaklyUpSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/MinMembersBeforeUpSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/NodeChurnSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/NodeDowningAndBeingRemovedSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/QuickRestartSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/RestartFirstSeedNodeSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/RestartNode2Spec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/RestartNode3Spec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/RestartNodeSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/Routing/ClusterBroadcastRouter2266BugfixSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/Routing/ClusterConsistentHashingRouterSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/Routing/ClusterRoundRobinSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/Routing/UseRoleIgnoredSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/SingletonClusterSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/SplitBrainResolverDowningSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/SplitBrainSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/SunnyWeatherSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/SurviveNetworkInstabilitySpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/TransitionSpec.cs
#	src/core/Akka.Cluster.Tests.MultiNode/UnreachableNodeJoinsAgainSpec.cs
#	src/core/Akka.Cluster.Tests/ActorRefProvidersConfigSpec.cs
#	src/core/Akka.Cluster.Tests/ClusterDeployerSpec.cs
#	src/core/Akka.Cluster.Tests/ClusterSpec.cs
#	src/core/Akka.Cluster.Tests/ClusterSpecBase.cs
#	src/core/Akka.Cluster.Tests/DowningProviderSpec.cs
#	src/core/Akka.Cluster.Tests/ShutdownAfterJoinSeedNodesSpec.cs
#	src/core/Akka.Cluster.Tests/SplitBrainResolverConfigSpec.cs
#	src/core/Akka.Cluster.Tests/StartupWithOneThreadSpec.cs
#	src/core/Akka.Cluster/ClusterActorRefProvider.cs
#	src/core/Akka.Cluster/Configuration/ClusterConfigFactory.cs
#	src/core/Akka.Cluster/Routing/ClusterRoutingConfig.cs
#	src/core/Akka.MultiNodeTestRunner.Shared.Tests/ParsingSpec.cs
#	src/core/Akka.Persistence.Query.Tests/DummyReadJournal.cs
#	src/core/Akka.Persistence.TCK.Tests/LocalSnapshotStoreSpec.cs
#	src/core/Akka.Persistence.TCK.Tests/MemorySnapshotStoreSpec.cs
#	src/core/Akka.Persistence.TCK/Journal/JournalSpec.cs
#	src/core/Akka.Persistence.TCK/Serialization/JournalSerializationSpec.cs
#	src/core/Akka.Persistence.TCK/Serialization/SnapshotStoreSerializationSpec.cs
#	src/core/Akka.Persistence.TCK/Snapshot/SnapshotStoreSpec.cs
#	src/core/Akka.Persistence.Tests/AtLeastOnceDeliveryFailureSpec.cs
#	src/core/Akka.Persistence.Tests/EndToEndEventAdapterSpec.cs
#	src/core/Akka.Persistence.Tests/Fsm/PersistentFSMSpec.cs
#	src/core/Akka.Persistence.Tests/Journal/SteppingMemoryJournal.cs
#	src/core/Akka.Persistence.Tests/ManyRecoveriesSpec.cs
#	src/core/Akka.Persistence.Tests/MemoryEventAdapterSpec.cs
#	src/core/Akka.Persistence.Tests/OptionalSnapshotStoreSpec.cs
#	src/core/Akka.Persistence.Tests/PersistenceConfigAutoStartSpec.cs
#	src/core/Akka.Persistence.Tests/PersistenceSpec.cs
#	src/core/Akka.Persistence.Tests/PersistentActorJournalProtocolSpec.cs
#	src/core/Akka.Persistence.Tests/PersistentActorRecoveryTimeoutSpec.cs
#	src/core/Akka.Persistence.Tests/RecoveryPermitterSpec.cs
#	src/core/Akka.Persistence.Tests/Serialization/MessageSerializerRemotingSpec.cs
#	src/core/Akka.Persistence.Tests/Serialization/SerializationSpec.cs
#	src/core/Akka.Persistence/Persistence.cs
#	src/core/Akka.Remote.TestKit/Internals/TestConductorConfigFactory.cs
#	src/core/Akka.Remote.TestKit/MultiNodeSpec.cs
#	src/core/Akka.Remote.Tests.MultiNode/NewRemoteActorSpec.cs
#	src/core/Akka.Remote.Tests.MultiNode/PiercingShouldKeepQuarantineSpec.cs
#	src/core/Akka.Remote.Tests.MultiNode/RemoteDeliverySpec.cs
#	src/core/Akka.Remote.Tests.MultiNode/RemoteDeploymentDeathWatchSpec.cs
#	src/core/Akka.Remote.Tests.MultiNode/RemoteGatePiercingSpec.cs
#	src/core/Akka.Remote.Tests.MultiNode/RemoteNodeDeathWatchSpec.cs
#	src/core/Akka.Remote.Tests.MultiNode/RemoteNodeRestartDeathWatchSpec.cs
#	src/core/Akka.Remote.Tests.MultiNode/RemoteNodeRestartGateSpec.cs
#	src/core/Akka.Remote.Tests.MultiNode/RemoteNodeShutdownAndComesBackSpec.cs
#	src/core/Akka.Remote.Tests.MultiNode/RemoteQuarantinePiercingSpec.cs
#	src/core/Akka.Remote.Tests.MultiNode/RemoteReDeploymentSpec.cs
#	src/core/Akka.Remote.Tests.MultiNode/RemoteRestartedQuarantinedSpec.cs
#	src/core/Akka.Remote.Tests.MultiNode/TransportFailSpec.cs
#	src/core/Akka.Remote.Tests.Performance/ForkJoinDispatcherRemoteMessagingThroughputSpec.cs
#	src/core/Akka.Remote.Tests.Performance/InboundMessageDispatcherSpec.cs
#	src/core/Akka.Remote.Tests.Performance/ThreadPoolDispatcherRemoteMessagingThroughputSpec.cs
#	src/core/Akka.Remote.Tests.Performance/Transports/HeliosRemoteMessagingThroughputSpec.cs
#	src/core/Akka.Remote.Tests.Performance/Transports/TestTransportAssociationStressSpec.cs
#	src/core/Akka.Remote.Tests.Performance/Transports/TestTransportRemoteMessagingThroughputSpec.cs
#	src/core/Akka.Remote.Tests/ActorsLeakSpec.cs
#	src/core/Akka.Remote.Tests/RemoteDeathWatchSpec.cs
#	src/core/Akka.Remote.Tests/RemoteMessageLocalDeliverySpec.cs
#	src/core/Akka.Remote.Tests/RemoteMetricsSpec.cs
#	src/core/Akka.Remote.Tests/RemoteRouterSpec.cs
#	src/core/Akka.Remote.Tests/RemotingSpec.cs
#	src/core/Akka.Remote.Tests/RemotingTerminatorSpecs.cs
#	src/core/Akka.Remote.Tests/Serialization/DaemonMsgCreateSerializerSpec.cs
#	src/core/Akka.Remote.Tests/Serialization/MiscMessageSerializerSpec.cs
#	src/core/Akka.Remote.Tests/TransientSerializationErrorSpec.cs
#	src/core/Akka.Remote.Tests/Transport/AkkaProtocolSpec.cs
#	src/core/Akka.Remote.Tests/Transport/AkkaProtocolStressTest.cs
#	src/core/Akka.Remote.Tests/Transport/Bug3370DotNettyLinuxBufferPoolSpec.cs
#	src/core/Akka.Remote.Tests/Transport/DotNettySslSupportSpec.cs
#	src/core/Akka.Remote.Tests/Transport/DotNettyTransportShutdownSpec.cs
#	src/core/Akka.Remote.Tests/Transport/ThrottlerTransportAdapterSpec.cs
#	src/core/Akka.Remote.Tests/UntrustedSpec.cs
#	src/core/Akka.Remote/Configuration/RemoteConfigFactory.cs
#	src/core/Akka.Remote/Serialization/MiscMessageSerializer.cs
#	src/core/Akka.Streams.TestKit.Tests/Utils.cs
#	src/core/Akka.Streams.Tests.Performance/FlowSelectBenchmark.cs
#	src/core/Akka.Streams.Tests.Performance/MaterializationBenchmark.cs
#	src/core/Akka.Streams.Tests.Performance/MergeManyBenchmark.cs
#	src/core/Akka.Streams.Tests.TCK/AkkaPublisherVerification.cs
#	src/core/Akka.Streams.Tests.TCK/AkkaSubscriberVerification.cs
#	src/core/Akka.Streams.Tests/Actor/ActorPublisherSpec.cs
#	src/core/Akka.Streams.Tests/Actor/ActorSubscriberSpec.cs
#	src/core/Akka.Streams.Tests/Dsl/ActorRefBackpressureSinkSpec.cs
#	src/core/Akka.Streams.Tests/Dsl/ActorRefSinkSpec.cs
#	src/core/Akka.Streams.Tests/Dsl/FlowAskSpec.cs
#	src/core/Akka.Streams.Tests/Dsl/FlowSpec.cs
#	src/core/Akka.Streams.Tests/Dsl/StreamRefsSpec.cs
#	src/core/Akka.Streams.Tests/IO/TcpHelper.cs
#	src/core/Akka.Streams.Tests/Implementation/GraphStageLogicSpec.cs
#	src/core/Akka.Streams/ActorMaterializer.cs
#	src/core/Akka.TestKit/Configs/TestConfigs.cs
#	src/core/Akka.TestKit/TestKitBase.cs
#	src/core/Akka.Tests.Performance/Dispatch/DefaultDispatcherColdThroughputSpec.cs
#	src/core/Akka.Tests.Performance/Dispatch/ForkJoinDispatcherThroughputSpec.cs
#	src/core/Akka.Tests.Performance/Dispatch/MailboxMemoryFootprintSpec.cs
#	src/core/Akka.Tests.Performance/Dispatch/MessageDispatchAndReceiveBenchmark.cs
#	src/core/Akka.Tests.Performance/Dispatch/ReceiveOnlyBenchmark.cs
#	src/core/Akka.Tests.Performance/IO/TcpHorizontalScaleSpec.cs
#	src/core/Akka.Tests.Shared.Internals/AkkaSpec.cs
#	src/core/Akka.Tests/Actor/ActorSystemSpec.cs
#	src/core/Akka.Tests/Actor/CoordinatedShutdownSpec.cs
#	src/core/Akka.Tests/Actor/DeployerSpec.cs
#	src/core/Akka.Tests/Actor/Dispatch/CurrentSynchronizationContextDispatcherSpecs.cs
#	src/core/Akka.Tests/Actor/PropsCreationSpec.cs
#	src/core/Akka.Tests/Actor/Scheduler/SchedulerShutdownSpec.cs
#	src/core/Akka.Tests/Dispatch/DispatchersSpec.cs
#	src/core/Akka.Tests/Routing/ResizerSpec.cs
#	src/core/Akka.Tests/Serialization/CustomSerializerSpec.cs
#	src/core/Akka.Tests/Serialization/NewtonsoftJsonConfigSpec.cs
#	src/core/Akka.Tests/Serialization/SerializationSpec.cs
#	src/core/Akka/Actor/CoordinatedShutdown.cs
#	src/core/Akka/Actor/Deploy.cs
#	src/core/Akka/Dispatch/AbstractDispatcher.cs
#	src/core/Akka/Dispatch/CachingConfig.cs
#	src/core/Akka/Dispatch/FlatConfig.cs
#	src/core/Akka/Dispatch/Mailboxes.cs
#	src/core/Akka/Serialization/NewtonSoftJsonSerializer.cs
#	src/examples/Chat/ChatClient/Program.cs
#	src/examples/Chat/ChatServer/Program.cs
#	src/examples/Cluster/Roles/Samples.Cluster.Transformation/Program.cs
#	src/examples/Cluster/Samples.Cluster.Simple/Program.cs
@Arkatufus Arkatufus marked this pull request as ready for review February 27, 2020 22:58
@Aaronontheweb
Copy link
Member

Akka.Cluster.Metrics.Tests.MultiNode.AdaptiveLoadBalancingRouterSpec.txt - failed in both environments. Hard failure.

@Arkatufus
Copy link
Contributor Author

Akka.Cluster.Metrics.Tests.MultiNode.AdaptiveLoadBalancingRouterSpec failed because a Config instance is passed as an argument to a function that expects an array. The config file then tried to expand itself into an array and failed.

@Arkatufus Arkatufus requested a review from Aaronontheweb March 1, 2020 08:51
@Arkatufus Arkatufus deleted the Simplified_Hocon_data_structure branch February 27, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants