Improper value instantiation and parenting during parsing caused a disconnected tree nodes. #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt proper self-referencing substitution backtracking.
Arkatufus
changed the title
|
Oh my ... |
|
No problem, it's kind of my responsibility, since it was my code in the first place. |
Aaronontheweb
pushed a commit
that referenced
this pull request
Jul 29, 2019
* Simplify HoconField constructor * Strict node parenting for cleaner object reconstruction * Reverse all object value upkeep responsibility to the parser to support proper self-referencing substitution backtracking. * Remove HoconValue.Undefined * Merge clean-up, remove HoconValue.Undefined references. * Merge cleanup
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
Improper value instantiation and parenting during parsing caused a disconnected tree node, causing self-referencing substitution to fail to find the proper old value to backtrack to.
Fix:
Fix #95
Fix #97