Skip to content

Fix a windows EOL bug for test case #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2019
Merged

Conversation

iron9light
Copy link
Contributor

This test case will be failed when run on windows.

@Arkatufus
Copy link
Contributor

I don't get it, what are you trying to do here, exactly?

@iron9light
Copy link
Contributor Author

My working OS is windows, and my git setting is keeping EOL as git remote source.

In your code, the EOL of the json like string is \n, and I guess config.PrettyPrint will use Environment.NewLine as EOL for output print string, which means \r\n in my environment.
Then the string assert will be failed.

Since EOL depends on OS and git global settings, it's not easy to contral it. We should ignore EOL in the code logic.

@Arkatufus Arkatufus merged commit b323b49 into akkadotnet:dev Jun 21, 2019
@Arkatufus
Copy link
Contributor

Thanks for the PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants