Code cleanup #77
Merged
Code cleanup #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arkatufus
commented
Feb 24, 2019
•
Arkatufus
commented
- Simplify object parsing.
- Fix end of line parsing bugs that causes object and array parsing.
- Resolves Bug when reading array of objects #75
- Merge and closes Fix substitution in array cases. #73 pull request
- Resolves array does not support substitution #70
- Merge and closes Fix problems with file system reading in CI #74 pull request
- Fix problems with CI not running test in their build directory causing it to fail to read included external test files.
…ect and array parsing errors.
…on.Configuration build target to net461, Add hack so configuration works with unit test.
…kkadotnet#80) * Modernized build system in preparation for Azure Pipelines migration * deleted rest of restore packages usages
Made project Linux-friendly.
|
@Arkatufus unfortunately the file renames I did to make builds run on Linux appear to have created some conflict issues here - best bet is to rebase probably |
|
CI should play much more nicely now though |
…ect and array parsing errors.
|
@Aaronontheweb, Seems like at least one file were not copied from the git repo to the build directory in Linux PR validation build. Build failed on Hocon.Configuration.Test because it could not find the app.config file in the source directory. |
Aaronontheweb
requested changes
Mar 18, 2019
Aaronontheweb
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.