-
Notifications
You must be signed in to change notification settings - Fork 40
Hocon improvement. #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Hocon improvement. #218
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b1cd465
Add IEquatable<Config> interface implementation
Arkatufus a8fc652
Revert Hocon to spec.
Arkatufus a84d81a
Move ConfigurationException from Akka.Configuration to Hocon, code cl…
Arkatufus 0f85f06
Fix Config.WithFallback() with hocon files containing substitution fa…
Arkatufus 2fd97dc
Merge remote-tracking branch 'upstream/dev' into Add_IEquitable
Arkatufus af13dc5
Fix Hocon parsing failed with substitution inside a literal
Arkatufus cca4cec
Add default constructor to HoconObject for Hyperion support.
Arkatufus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,14 @@ public class HoconConfigurationSection : ConfigurationSection | |
/// Retrieves a <see cref="Config" /> from the contents of the | ||
/// custom akka node within a configuration file. | ||
/// </summary> | ||
public Config Config => _config ?? (_config = ConfigurationFactory.ParseString(Hocon.Content)); | ||
public Config Config { | ||
get | ||
{ | ||
if (_config == null && !string.IsNullOrWhiteSpace(Hocon.Content)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good optimization |
||
_config = ConfigurationFactory.ParseString(Hocon.Content); | ||
return _config; | ||
} | ||
} | ||
|
||
/// <summary> | ||
/// Retrieves the HOCON (Human-Optimized Config Object Notation) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is the reproduction case you were talking about. Good, glad we have it.