Fix Hocon to work with Akka.NET #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Feb 10, 2020
| @@ -577,6 +577,28 @@ public void ShouldSerializeFallbackValues() | |||
|
|
|||
| } | |||
|
|
|||
| [Fact] | |||
| public void WithFallback_ShouldNotChangeOriginalConfig() | |||
| /// <exception cref="T:System.ArgumentNullException">"The root value cannot be null."</exception> | ||
| public Config(HoconRoot root) : base(root?.Value, root?.Substitutions ?? Enumerable.Empty<HoconSubstitution>()) |
| } | ||
| } | ||
|
|
||
| return _mergedValueCache; |
There was a problem hiding this comment.
I think this is a good idea - caching this value for future computations.
| /// </summary> | ||
| /// <param name="fallback">The configuration to use as a secondary source.</param> | ||
| /// <returns>The current configuration configured with the specified fallback.</returns> | ||
| /// <exception cref="ArgumentException">Config can not have itself as fallback.</exception> | ||
| public virtual Config WithFallback(Config fallback) | ||
| { | ||
| if (fallback == this) | ||
| if (ReferenceEquals(fallback, this)) |
There was a problem hiding this comment.
Yep, that's the right call - since we might overload ==
| return Copy(Fallback.SafeWithFallback(fallback)); | ||
|
|
||
| if (IsEmpty) | ||
| return fallback; |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to akkadotnet/akka.net#4128
Parserclass name toHoconParser