Skip to content

Use fallback values of fallbacks when calculating final config #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Use fallback values of fallbacks when calculating final config #198

wants to merge 2 commits into from

Conversation

IgorFedchenko
Copy link
Contributor

@IgorFedchenko IgorFedchenko commented Jan 24, 2020 •
edited
Loading

Close #196

Basically instead of taking config.Fallback.Value we should use config.Fallback.Root, because Root is aware of fallback values, while Value is not.

@Aaronontheweb This is based on #197, so may need to merge that one first

@IgorFedchenko IgorFedchenko mentioned this pull request Jan 24, 2020
Merged
@IgorFedchenko
Copy link
Contributor Author

Actually, this is a mistake. it is working well with Fallback.Value since we are iterating all Fallbacks and getting values from them. So taking Root instead of Value from each fallback is just a loose of resources.

Closing this as well.

@IgorFedchenko IgorFedchenko deleted the fix/fallback-for-fallback branch January 24, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using config with fallback as fallback for another config looses fallback values
1 participant
@IgorFedchenko