Skip to content

fix string unquoting upon parse #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2020

Conversation

Aaronontheweb
Copy link
Member

closes #190

@Aaronontheweb Aaronontheweb marked this pull request as ready for review January 23, 2020 00:47
@Aaronontheweb Aaronontheweb changed the title [WIP] fix string unquoting upon parse fix string unquoting upon parse Jan 23, 2020
@Aaronontheweb
Copy link
Member Author

So this isn't a bug with the parser - it's an API change. The original HoconValue.ToString() method return the unquoted string, but we also didn't have proper support for merging and flattening of HOCON back then. Now we do, but the consequence is that the raw HOCON is what needs to be exposed during those ToString operations on that HOCON.

Thus, we also have the HoconValue.GetString() method - which returns the human-usable value that we are likely looking for inside our applications which consume HOCON. I've updated the XML-DOC comments to reflect this little gotcha, but otherwise it's not a bug that can be easily addressed without breaking something more nasty like object merging.

@Aaronontheweb Aaronontheweb merged commit 32ca43b into akkadotnet:dev Jan 23, 2020
@Aaronontheweb Aaronontheweb deleted the fix-190-string-quoting branch January 23, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent un-quoting of quoted strings upon parse
1 participant