Skip to content

Fixed empty config deserialization #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IgorFedchenko
Copy link
Contributor

Close #175

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -14,6 +14,8 @@ namespace Hocon
/// </summary>
public sealed class HoconEmptyValue : HoconValue
{
public HoconEmptyValue() : base(null) { }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

restored.IsEmpty.Should().BeTrue();
}

internal class AkkaContractResolver : DefaultContractResolver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical to what we have inside the Akka.NET project, in case that's now clear to other project members:

https://github.com/akkadotnet/akka.net/blob/0a8c0390ee24927e3c381a99bca079ebc7e5b8e9/src/core/Akka/Serialization/NewtonSoftJsonSerializer.cs#L187-L205

@Aaronontheweb Aaronontheweb merged commit c718aa0 into akkadotnet:dev Jan 16, 2020
@IgorFedchenko IgorFedchenko deleted the fix/config-deserialization branch January 16, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Akka.Configuration.Hocon backward compatibility: Config object deserialization from json
2 participants