change HoconType to describe content of literals #164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
added a commit
to Aaronontheweb/HOCON
that referenced
this pull request
Jan 14, 2020
Merged
Aaronontheweb
added a commit
that referenced
this pull request
Jan 15, 2020
* made most accessor properties of HoconRoot virtual * made GetConfig and GetString virtual * added IsString extension method Needed for CachingConfig inside akkadotnet/akka.net#4128 * added Config.Empty Added for brevity and API backwards-compatibility with Akka.Hocon. * Added AtKey implementation for HoconValue * testing IsString method * change HoconType to describe content of literals * fixed compilation issues * implementing notion of type mergability, separate from displayed type * completed mergeability implementation * integrated #164 and #163 together for testing purposes * bumped to 1.2.2 * added additional Fallback test cases * ConfigurationFactor.Empty.IsEmpty == true now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this so it's easier to use the HOCON schema to determine what the content of underlying objects are and it brings us closer to the
ConfigTypein the original Scala implementation of HOCON.