-
Notifications
You must be signed in to change notification settings - Fork 40
Overloads with values for HoconRoot getters #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
(I still don't know why Azure DevOps isn't showing status for PRs in this repository - only shows status for code once it's directly merged into |
Yup, the behavior asserted in this test was incorrect actually, so fixed it too |
@IgorFedchenko looks like the CI system is not our friend still |
@Aaronontheweb Yup... In Akka.NET also not all steps are completed. Looking at issue here, they still did not resolve this problem. |
|
@IgorFedchenko have a merge conflict here |
Since #148 was based in this PR, the changes are already in dev branch, and #148 overwrites some of them. |
Thanks @IgorFedchenko |
Related to #108
First, existing overloads like
obj.GetDouble("a", @default: 5)
did not work, because it was expecting underlyingGetNode
to returnnull
when path was not found, but it was throwing exception (which is generally good thing, but here needed to catch it).Second - there was no way to specify default value for collection getters (i.e. if I want to get empty list of ids if they are not set - the only options was to handle exception). Added this overloads, and added test for all of them.