Fix config.ToString #143
Merged
Fix config.ToString #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorFedchenko
commented
Dec 14, 2019
| @@ -19,7 +19,7 @@ public sealed class HoconImmutableLiteral : HoconImmutableElement, IEquatable<Ho | |||
| { | |||
| public static readonly HoconImmutableLiteral Null = HoconImmutableLiteral.Create(null); | |||
|
|
|||
| public string Value { get; } | |||
| public new string Value { get; } | |||
There was a problem hiding this comment.
This is not related, but fixes annoying compiler warning
IgorFedchenko
commented
Dec 14, 2019
| @@ -681,7 +681,7 @@ internal void ReParent(HoconValue value) | |||
| /// <returns>A HOCON string representation of this <see cref="HoconValue"/>.</returns> | |||
| public override string ToString() | |||
| { | |||
| return ToString(0, 2); | |||
| return ToString(1, 2); | |||
There was a problem hiding this comment.
Seems like someone changed ToString implementation during debugging something and did not update this ToString overload.
Aaronontheweb
pushed a commit
that referenced
this pull request
Dec 27, 2019
* Fixed config.ToString indent exception * Minor warning fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #108
Actually,
config.ToString()was throwing exception always, fixed now.