Skip to content

Fields merging not works as expected for Hocon.Extensions.Configuration #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iron9light opened this issue May 30, 2019 · 4 comments
Closed

Fields merging not works as expected for Hocon.Extensions.Configuration #89

iron9light opened this issue May 30, 2019 · 4 comments

Comments

@iron9light
Copy link
Contributor

iron9light commented May 30, 2019 •
edited
Loading

Input:

a {
  aa: 1
  bb: "2"
}

a {
  cc: 3.3
}

What's expected:
(I've tried it on https://hocon-playground.herokuapp.com/ )

a:aa: "1"
a:bb: "2"
a:cc: "3.3"

But was:

a:cc: "3.3"
@iron9light iron9light changed the title Fields merging not works as expected Fields merging not works as expected for Hocon.Extensions.Configuration May 30, 2019
@iron9light iron9light mentioned this issue May 30, 2019
Closed
@Arkatufus
Copy link
Contributor

Working on a fix, thank you for reporting.

@iron9light
Copy link
Contributor Author

I've fixed this bug. See my PR #91

@iron9light
Copy link
Contributor Author

Another PR #88 . Please check it out.

Arkatufus added a commit to Arkatufus/HOCON that referenced this issue Jun 4, 2019
@Arkatufus
Fix for akkadotnet#89 and akkadotnet#92, Object fields containing obj…
d9bb066 
…ects may not return the proper object value in certain circumstances.
@Arkatufus Arkatufus mentioned this issue Jun 4, 2019
Merged
@Arkatufus
Copy link
Contributor

Its OK, I've made a fix for both #89 and #92, they're related.

Aaronontheweb pushed a commit that referenced this issue Jun 6, 2019
@Arkatufus @Aaronontheweb
Fix for #89 and #92, Object fields containing objects may not return …
ef70a15 
…the proper object value in certain circumstances. (#93)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iron9light @Arkatufus