Skip to content

Conventional configuration files #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ismaelhamed opened this issue Dec 29, 2019 · 3 comments · Fixed by #249 or #260
Closed

Conventional configuration files #159

ismaelhamed opened this issue Dec 29, 2019 · 3 comments · Fixed by #249 or #260
Milestone

Comments

@ismaelhamed
Copy link
Member

Being a "C# implementation of Lightbend's HOCON", what's the reasoning for diverging from the convention of loading from files named application.{conf,json,properties} by default?

@Aaronontheweb
Copy link
Member

Are you referring to #48 or is there something else I'm missing?

@ismaelhamed
Copy link
Member Author

This is more of a cosmetic issue I guess, but currently ConfigurationFactory.Default will only try to load app.{conf,hocon} files, whereas Lightbend's loads from application.{conf,json,properties}. It is in an application.conf file where you'll traditionally find Akka's configuration in the JVM.

@Aaronontheweb
Copy link
Member

@Arkatufus guess we should redo this one - liked the original change but it need to go into the Default() method, not Load(), which has historical consequences

Aaronontheweb added a commit that referenced this issue Mar 5, 2020
* Change the default file names and load priority

* Move codes from Load() to Default()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants