Force write journal to initialize when read journal is started #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Jul 29, 2024
|
|
||
| namespace Akka.Persistence.Sql.Tests.Common.Query | ||
| { | ||
| public abstract class Bugfix344Spec<T> : Akka.TestKit.Xunit2.TestKit, IAsyncLifetime where T : ITestContainer |
There was a problem hiding this comment.
Abstract spec to validate that this issue has been resolved, and that the ReadJournal will automatically start up the write journal and wait for it to initialize.
| @@ -59,6 +59,11 @@ public class SqlReadJournal : | |||
| _system = system; | |||
|
|
|||
| var connFact = new AkkaPersistenceDataConnectionFactory(_readJournalConfig); | |||
|
|
|||
| // Fix for https://github.com/akkadotnet/Akka.Persistence.Sql/issues/344 | |||
| var writeJournal = Persistence.Instance.Apply(system).JournalFor(writePluginId); | |||
There was a problem hiding this comment.
Start the SqlWriteJournal if it has not been started already - technically the _eventAdapters = Persistence.Instance.Apply(system).AdaptersFor(writePluginId); also does this implicitly.
| // Fix for https://github.com/akkadotnet/Akka.Persistence.Sql/issues/344 | ||
| var writeJournal = Persistence.Instance.Apply(system).JournalFor(writePluginId); | ||
| // we want to block, we want to crash if the journal is not available | ||
| var started = writeJournal.Ask<Initialized>(IsInitialized.Instance, TimeSpan.FromSeconds(5)).Result; |
There was a problem hiding this comment.
Block and wait until startup is complete - this should cover any cases of this issue where queries still get executed before the write journal fully finishes initializing.
|
Got the error to occur: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
close #344
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):