Store the gradle plugin logfile inside the build directory #674
Conversation
…ct directory is not in C:\
|
Hi @hithran, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged. For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask! |
hithran
changed the title
|
OK TO TEST |
|
Thank you Travis for saving me from trouble with my hasty PR creation. I'll be a like a good dev and run the tests before I push changes ^^ |
* Fixed log file issue with the gradle plugin on windows when the project directory is not in C:\ * Fixed the printProtoLogs task, it referred to a removed property.
* Fixed log file issue with the gradle plugin on windows when the project directory is not in C:\ * Fixed the printProtoLogs task, it referred to a removed property.
Purpose
The location of the logfile is changed from the users temp directory to the gradle build directory.
This in order to prevent an issues when using the plugin on Windows while the project folder is not on
C:\References
References #669
Changes
Background Context
As discussed in #669, there is a split on
:when passing the logfile location, which complicates the approach of passing a Windows path with a drive letter. Writing the logfile to the gradle build directory seems the next best thing when trying to get it all to work.