Remove optional type from the validation context parameter #1747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What version of Ajv are you using? Does the issue happen if you use the latest version?
8.6.2, happens in the latest version
Your typescript code
Typescript compiler error messages
It means that the
dataCxt
object is possibly 'undefined'.Describe the change that should be made to address the issue?
Remove the optional
?
operator from thedataCxt
parameter inValidateFunction
andSchemaValidateFunction
interface types.I've checked the generated code, and the validation context object is always passed to the validation function. Also the codegen validateFunction seems to always include the validation context (although I'm not familiar with codegen itself, so I may be wrong here).
Are you going to resolve the issue?
Yes. The PR removes the optional operator from
dataCxt
and renamesDataValidationCxt
toValidationCxt
&dataCxt
tovalCxt
to match the codegen function.