Skip to content

add editor.destroyed property #5785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nightwing
Copy link
Member

  • add editor.destroyed property
  • keep $toDestroy as array even after destroying to prevent calling methods of destroyed editor from throwing errors
  • prevent space scrolling editor out of view in readonly mode

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.25%. Comparing base (78ad9c7) to head (3d76701).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5785   +/-   ##
=======================================
  Coverage   87.24%   87.25%           
=======================================
  Files         604      604           
  Lines       44305    44309    +4     
  Branches     7265     7267    +2     
=======================================
+ Hits        38656    38660    +4     
  Misses       5649     5649           
Flag Coverage Δ
unittests 87.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants