Skip to content

fix: replace NodeList.foreach with for loop #5769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

InspiredGuy
Copy link
Contributor

Issue #, if available:
#5766

Description of changes:
Fix for old browsers. Replace NodeList.forEach() with for loop, since forEach is not available before Firefox 50 (see docs).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

@InspiredGuy InspiredGuy requested a review from nightwing March 10, 2025 09:15
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.10%. Comparing base (cd78a94) to head (2ffd5ee).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5769   +/-   ##
=======================================
  Coverage   87.10%   87.10%           
=======================================
  Files         602      602           
  Lines       44092    44092           
  Branches     7234     7234           
=======================================
  Hits        38407    38407           
  Misses       5685     5685           
Flag Coverage Δ
unittests 87.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@InspiredGuy InspiredGuy merged commit b3de3c1 into master Mar 10, 2025
3 checks passed
@InspiredGuy InspiredGuy deleted the fix-indent-guide-old-browsers branch March 10, 2025 11:08
@InspiredGuy InspiredGuy mentioned this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants