fix: set completion popup role to 'menu' for safari #5403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5403 +/- ##
=======================================
Coverage 87.54% 87.54%
=======================================
Files 583 583
Lines 46216 46222 +6
Branches 6998 7001 +3
=======================================
+ Hits 40459 40465 +6
Misses 5757 5757
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The experience in other browsers is not affected by setting the |
|
@InspiredGuy not as far as I can tell, setting |
oykuyilmaz
approved these changes
Nov 28, 2023
This was referenced Dec 6, 2023
akoreman
added a commit
that referenced
this pull request
Dec 11, 2023
follow-up to #5403, we set the role to menuitem for items in the completer popup on webkit browsers but aria-selected is not allowed for menuitem roles triggering customers who run automated a11y tests. This changes it to aria-current which is allowed for this role.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #5377
Description of changes: On Safari,
aria-activedescendantis not supported for thelistboxrole but is supported for themenurole. This results in an unusable autocomplete for VoiceOver/Safari users. This changes the role tomenufor Safari to give some (but not perfect) support for this browser/screenreader combo:Screen.Recording.2023-11-28.at.11.17.37.mov
Sets
aria-roledescriptionto keep the behaviour somewhat consistent between the two flows. Setsaria-selectedfor the selected item, without it Safari/VoiceOver doesn't read the item.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.