Skip to content

🐛Source Github: remove BAD_GATEWAY code from backoff_time #9999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 9, 2022

Conversation

annalvova05
Copy link
Contributor

@annalvova05 annalvova05 commented Feb 2, 2022

What

Sync was failed and doesn't use backoff_time.

How

Remove BAD_GATEWAY code from backoff_time.

Recommended reading order

  1. streams.py

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added the area/connectors Connector related issues label Feb 2, 2022
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@ea1ad99). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9ad76b9 differs from pull request most recent head b04df34. Consider uploading reports for the commit b04df34 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9999   +/-   ##
=========================================
  Coverage          ?   56.63%           
=========================================
  Files             ?        3           
  Lines             ?      452           
  Branches          ?        0           
=========================================
  Hits              ?      256           
  Misses            ?      196           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea1ad99...b04df34. Read the comment docs.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Feb 2, 2022
@annalvova05 annalvova05 temporarily deployed to more-secrets February 2, 2022 11:13 Inactive
@annalvova05 annalvova05 linked an issue Feb 2, 2022 that may be closed by this pull request
@annalvova05
Copy link
Contributor Author

annalvova05 commented Feb 2, 2022

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1783584493
❌ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1783584493
🐛 https://gradle.com/s/c2p2kco6v4avg

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 2, 2022 11:25 Inactive
@annalvova05 annalvova05 temporarily deployed to more-secrets February 2, 2022 14:00 Inactive
@annalvova05
Copy link
Contributor Author

annalvova05 commented Feb 2, 2022

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1784289209
❌ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1784289209
🐛 https://gradle.com/s/2kvgctvhx7mim

@annalvova05 annalvova05 temporarily deployed to more-secrets February 2, 2022 14:07 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 2, 2022 14:10 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an unit test for this case with a mocked failed request

@annalvova05 annalvova05 temporarily deployed to more-secrets February 4, 2022 13:33 Inactive
@annalvova05
Copy link
Contributor Author

annalvova05 commented Feb 8, 2022

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1812092549
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1812092549
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/tests/test_incremental.py        69     38    45%
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                        Stmts   Miss  Cover
-----------------------------------------------
source_github/__init__.py       2      0   100%
source_github/source.py        78     35    55%
source_github/streams.py      373    161    57%
-----------------------------------------------
TOTAL                         453    196    57%

@annalvova05 annalvova05 temporarily deployed to more-secrets February 8, 2022 11:59 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 8, 2022 12:00 Inactive
@annalvova05 annalvova05 requested a review from antixar February 8, 2022 12:01
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please publish your changes

@annalvova05
Copy link
Contributor Author

annalvova05 commented Feb 9, 2022

/publish connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1817110644
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1817110644

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 9, 2022 09:10 Inactive
@annalvova05 annalvova05 merged commit 8749c7a into master Feb 9, 2022
@annalvova05 annalvova05 deleted the alvova/5963-github-backoff branch February 9, 2022 10:10
@annalvova05 annalvova05 temporarily deployed to more-secrets February 9, 2022 10:11 Inactive
@lazebnyi lazebnyi removed their request for review May 30, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Native Connector: max retries hit, terminates
3 participants