-
Notifications
You must be signed in to change notification settings - Fork 4.5k
🐛Source Github: remove BAD_GATEWAY code from backoff_time #9999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9999 +/- ##
=========================================
Coverage ? 56.63%
=========================================
Files ? 3
Lines ? 452
Branches ? 0
=========================================
Hits ? 256
Misses ? 196
Partials ? 0 Continue to review full report at Codecov.
|
/test connector=connectors/source-github
|
/test connector=connectors/source-github
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an unit test for this case with a mocked failed request
/test connector=connectors/source-github
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please publish your changes
/publish connector=connectors/source-github
|
What
Sync was failed and doesn't use backoff_time.
How
Remove BAD_GATEWAY code from backoff_time.
Recommended reading order
streams.py
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here